Skip to content

[feat] Enhance workflow template card UI #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[feat] Enhance workflow template card UI #5807

wants to merge 2 commits into from
+24 −33

Conversation

felixturner
Copy link

@felixturner felixturner commented Sep 26, 2025 •
edited by sync-by-unito bot
Loading

Summary

Small tweaks to #5142 to improve template card UI. Providing more context and readbility

Changes

  • Move tutorial button to overlay on template image to avoid content shift on hover
  • Increase description text display from 2 to 5 lines for more context
  • Increase title size for readability
  • Improve card layout: larger image, cleaner borders and padding
  • Update SquareChip background for visual consistency (bg-black/20)

Screenshots

Before

before

After

after

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

🎭 Playwright Test Results

loading Tests are starting...

⏰ Started at: 09/28/2025, 06:13:25 PM UTC

🚀 Running Tests

  • 🧪 chromium: Running tests...
  • 🧪 chromium-0.5x: Running tests...
  • 🧪 chromium-2x: Running tests...
  • 🧪 mobile-chrome: Running tests...

⏱️ Please wait while tests are running...

@felixturner felixturner mentioned this pull request Sep 26, 2025
Closed
@Myestery Myestery added the Design Used to request Product feedback on design decisions label Sep 26, 2025
@felixturner
Copy link
Author

Not sure why linting is failing. Claude tells me there is an issue in the workflow:

The GitHub Actions workflow lint-and-format.yaml is failing because it's trying to checkout the branch template-card-updates from the main repository (Comfy-Org/ComfyUI_frontend) instead of your fork
(felixturner/ComfyUI_frontend).

The Problem:
Line 19 in .github/workflows/lint-and-format.yaml is missing the repository parameter in the checkout step.

The Fix:
Add repository: ${{ github.event.pull_request.head.repo.full_name }} to the checkout step to make it work with PRs from forks.

Your Code Status:
✅ All local checks pass (lint, typecheck, format) - the issue is purely a workflow configuration bug in the main repository.

@felixturner
[feat] Enhance workflow template card UI
a1ab06a 
 - Move tutorial button to overlay on template image to avoid ceontent shift on hover
 - Increase description text display from 2 to 5 lines for more context
 - increase title size for readability
 - Improve card layout: larger image, cleaner borders and padding
 - Update SquareChip background for visual consistency (bg-black/20)
@Myestery
Copy link
Collaborator

Myestery commented Oct 8, 2025

Thank you @felixturner for all the work you've put into this PR. After review with the design team, we've decided to take a different direction for this feature particularly with the descriptions and the tutorial button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viva-jinyi viva-jinyi Awaiting requested review from viva-jinyi viva-jinyi is a code owner

@PabloWiedemann PabloWiedemann Awaiting requested review from PabloWiedemann

@snomiao snomiao Awaiting requested review from snomiao

At least 1 approving review is required to merge this pull request.

Assignees

@Myestery Myestery

Labels
Design Used to request Product feedback on design decisions size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixturner @Myestery